Node-prefixed requires #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset fixes and closes isaacs#16 so that this package can be used on all JS runtimes. Relates to isaacs/node-glob#580 Signed-off-by: Sam Gammon <[email protected]>
Runs `npm audit fix` to remedy: `word-wrap` vulnerable to Regular Expression Denial GHSA-j8xg-fqg3-53r7 Signed-off-by: Sam Gammon <[email protected]>
sgammon
force-pushed
the
feat/neutral-runtimes
branch
from
4f7197f to
cf46650
Compare
sgammon
added a commit
to sgammon/node-glob
that referenced
this pull request
Mar 31, 2024
Fixes and closes isaacs#580 by switching to `node:`- prefixed requires for Node API builtins. Will need releases for `minipass` and `path-scurry`, PRs for these are noted below. Relates to: - isaacs/path-scurry#17 - isaacs/minipass#55 Signed-off-by: Sam Gammon <[email protected]>
sgammon
added a commit
to sgammon/hashlock
that referenced
this pull request
Mar 31, 2024
- feat: support all popular js runtimes - patches for `glob`, `minipass`, and `path-scurry` - upstream prs (listed below) - test entrypoint commands - test: add test entrypoints for each major runtime - test: add scripts to test entrypoint with each major runtime - chore: sync lockfiles Related Issues - isaacs/node-glob#580 - isaacs/path-scurry#16 - isaacs/minipass#54 - tj/commander.js#2169 Upstream PRs - isaacs/node-glob#581 - isaacs/minipass#55 - isaacs/path-scurry#17 - tj/commander.js#2170 Signed-off-by: Sam Gammon <[email protected]>
sgammon
added a commit
to sgammon/hashlock
that referenced
this pull request
Mar 31, 2024
- feat: support all popular js runtimes - patches for `glob`, `minipass`, and `path-scurry` - upstream prs (listed below) - test entrypoint commands - test: add test entrypoints for each major runtime - test: add scripts to test entrypoint with each major runtime - chore: sync lockfiles Related Issues - isaacs/node-glob#580 - isaacs/path-scurry#16 - isaacs/minipass#54 - tj/commander.js#2169 Upstream PRs - isaacs/node-glob#581 - isaacs/minipass#55 - isaacs/path-scurry#17 - tj/commander.js#2170 Signed-off-by: Sam Gammon <[email protected]>
sgammon
added a commit
to sgammon/hashlock
that referenced
this pull request
Mar 31, 2024
- feat: support all popular js runtimes - patches for `glob`, `minipass`, and `path-scurry` - upstream prs (listed below) - test entrypoint commands - test: add test entrypoints for each major runtime - test: add scripts to test entrypoint with each major runtime - chore: sync lockfiles Related Issues - isaacs/node-glob#580 - isaacs/path-scurry#16 - isaacs/minipass#54 - tj/commander.js#2169 Upstream PRs - isaacs/node-glob#581 - isaacs/minipass#55 - isaacs/path-scurry#17 - tj/commander.js#2170 Signed-off-by: Sam Gammon <[email protected]>
sgammon
added a commit
to sgammon/hashlock
that referenced
this pull request
Mar 31, 2024
* feat: support all runtimes - feat: support all popular js runtimes - patches for `glob`, `minipass`, and `path-scurry` - upstream prs (listed below) - test entrypoint commands - test: add test entrypoints for each major runtime - test: add scripts to test entrypoint with each major runtime - chore: sync lockfiles Related Issues - isaacs/node-glob#580 - isaacs/path-scurry#16 - isaacs/minipass#54 - tj/commander.js#2169 Upstream PRs - isaacs/node-glob#581 - isaacs/minipass#55 - isaacs/path-scurry#17 - tj/commander.js#2170 Signed-off-by: Sam Gammon <[email protected]> * chore: version bump → `1.0.3` Signed-off-by: Sam Gammon <[email protected]> --------- Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>
isaacs
pushed a commit
to isaacs/node-glob
that referenced
this pull request
May 9, 2024
Fixes and closes #580 by switching to `node:`- prefixed requires for Node API builtins. Will need releases for `minipass` and `path-scurry`, PRs for these are noted below. Relates to: - isaacs/path-scurry#17 - isaacs/minipass#55 Signed-off-by: Sam Gammon <[email protected]> PR-URL: #581 Credit: @sgammon Close: #581 Reviewed-by: @isaacs
|
I doubt it'll be fixed, but for future record, this was a breaking change in a patch version. |
ljharb
added a commit
to ljharb/es-abstract
that referenced
this pull request
May 16, 2025
ljharb
added a commit
to ljharb/es-abstract
that referenced
this pull request
May 16, 2025
ljharb
added a commit
to ljharb/es-abstract
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset fixes and closes #16 by switching to node:-prefixed imports, which should be safe to assume support for now that Node 20 is LTS and Node 16 is EOL (Node 16 introduced this feature).
Related issues:
Peer PRs:
node:-prefixed requires for builtins node-glob#581