Skip to content

Conversation

jaybdub
Copy link

@jaybdub jaybdub commented Sep 24, 2025

Description

This PR adds the following changes

  1. Adds support for rendering images to Locomanipulation SDG envs
  2. Renames DisjointNav -> LocomanipulationSDG in docs and code

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added documentation Improvements or additions to documentation isaac-mimic Related to Isaac Mimic team labels Sep 24, 2025
@jaybdub jaybdub changed the title add camera to g1 locomanipulation env add camera to g1 locomanipulation env and update docs with G1.5 training note Oct 2, 2025
@yanchangNvidia
Copy link

Please add how you tested these changes.

@yanchangNvidia
Copy link

@ooctipus to review.

@jaybdub
Copy link
Author

jaybdub commented Oct 3, 2025

@yanchangNvidia -- These changes were tested by

  1. Running the datageneration pipeline with sample data
  2. Plotting the output trajectory
  3. Viewing images from dataset

Copy link

@yanchangNvidia yanchangNvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. Thank you for the changes. Left a few comments.

you may convert the generated dataset to LeRobot format as expected by GR00T N1.5, and then run the finetuning script provided
in the GR00T N1.5 repository. An example closed-loop policy rollout is shown in the video below:

.. figure:: https://download.isaacsim.omniverse.nvidia.com/isaaclab/images/locomanipulation_sdg_disjoint_nav_groot_policy_4x.gif

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change this gif name to "locomanipulation_sdg_groot_policy_4x.gif"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can but we need to ask for these images to be re-uploaded, I don't have direct access to do this.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Who can help us to get these images re-uploaded?

## Usage

To run the locomanipulation SDG replay script execute the following command.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need another step of running manipulation trajectory augmentation before the navigation trajectory augmentation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not needed, but desired. The script is generic, it can use the teleop dataset directly, or instead use the manipulation augmented trajectory.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. It would be great to add this information as a part of the documentation so that users know that they can use have another step to do the manipulation augmented trajectory before this step to scale up the data.

width=256,
data_types=["rgb"],
spawn=sim_utils.PinholeCameraCfg(focal_length=8.0, clipping_range=(0.1, 20.0)),
offset=CameraCfg.OffsetCfg(pos=(0.0, 0.0, 0.0), rot=(0.9848078, 0.0, -0.1736482, 0.0), convention="world"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was the "rot" setting chosen?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empirically to give a meaningful field of view that shows hands and grasping area

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. It might be good to add a comment on this setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation isaac-mimic Related to Isaac Mimic team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants