-
Notifications
You must be signed in to change notification settings - Fork 2.4k
add camera to g1 locomanipulation env and update docs with G1.5 training note #3549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/2.3.0
Are you sure you want to change the base?
add camera to g1 locomanipulation env and update docs with G1.5 training note #3549
Conversation
Please add how you tested these changes. |
@ooctipus to review. |
@yanchangNvidia -- These changes were tested by
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great. Thank you for the changes. Left a few comments.
you may convert the generated dataset to LeRobot format as expected by GR00T N1.5, and then run the finetuning script provided | ||
in the GR00T N1.5 repository. An example closed-loop policy rollout is shown in the video below: | ||
|
||
.. figure:: https://download.isaacsim.omniverse.nvidia.com/isaaclab/images/locomanipulation_sdg_disjoint_nav_groot_policy_4x.gif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change this gif name to "locomanipulation_sdg_groot_policy_4x.gif"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can but we need to ask for these images to be re-uploaded, I don't have direct access to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Who can help us to get these images re-uploaded?
## Usage | ||
|
||
To run the locomanipulation SDG replay script execute the following command. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need another step of running manipulation trajectory augmentation before the navigation trajectory augmentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not needed, but desired. The script is generic, it can use the teleop dataset directly, or instead use the manipulation augmented trajectory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. It would be great to add this information as a part of the documentation so that users know that they can use have another step to do the manipulation augmented trajectory before this step to scale up the data.
width=256, | ||
data_types=["rgb"], | ||
spawn=sim_utils.PinholeCameraCfg(focal_length=8.0, clipping_range=(0.1, 20.0)), | ||
offset=CameraCfg.OffsetCfg(pos=(0.0, 0.0, 0.0), rot=(0.9848078, 0.0, -0.1736482, 0.0), convention="world"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How was the "rot" setting chosen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empirically to give a meaningful field of view that shows hands and grasping area
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. It might be good to add a comment on this setting.
Description
This PR adds the following changes
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there