This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Force db refresh on builder #9432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a different ENV_VAR than FORCE_DB_REFRESH since the builder configmap starts with the builder's extraEnv, then overwrites it with api/client/instanceserver values. If builder's FORCE_DB_REFRESH is true but the api's is false, then it'll end up being false on the configmap. If we set the api's to true, then the api servers will do their own refresh, which we don't want.
DanielBelmes
approved these changes
Dec 12, 2023
|
nice |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using a different ENV_VAR than FORCE_DB_REFRESH since the builder configmap starts with the builder's extraEnv, then overwrites it with api/client/instanceserver values. If builder's FORCE_DB_REFRESH is true but the api's is false, then it'll end up being false on the configmap. If we set the api's to true, then the api servers will do their own refresh, which we don't want.
References
closes #9404
QA Steps