-
-
Notifications
You must be signed in to change notification settings - Fork 3
Updates for allowing domain-related hooks and logic #9322
Conversation
ba7cb8d
to
e7190d5
Compare
d27e712
to
ae6f027
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have gone through the code and it looks good. Though havn't got a chance to test the changes locally.
packages/server-core/src/recording/recording-resource-upload/recording-resource-upload.class.ts
Outdated
Show resolved
Hide resolved
43c3eb5
to
acb7cb4
Compare
@barankyle used this branch of EE, standalone. Without any project, etc. Just Recording.2023-11-29.141713.mp4 |
03e148d
to
0e48f12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like putting headers in the actions. It's a security risk and can be done cleaner.
e0c78f1
to
15519d7
Compare
Do we need these changes after #9371 |
15519d7
to
e52ff96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check-errors
seems to be failing.
packages/server-core/src/media/upload-asset/upload-asset.hooks.ts
Outdated
Show resolved
Hide resolved
packages/server-core/src/recording/recording-resource-upload/recording-resource-upload.hooks.ts
Outdated
Show resolved
Hide resolved
992fc7c
to
9dbbf7d
Compare
e5532bd
to
10c0aa5
Compare
Internal listeners that send messages to interested clients need to persist headers on calls, as original headers are not preserved. Fixed issues with email/SMS generation. Made some resolver get's internal _get's, in cases where headers may not be available at that point. All instances are cases where headers might actively interfere with the process, e.g. looking up static resources that might not have a field populated from headers. Converetd uploadMediaStaticResource and uploadRecordingStaticResource into a single new service. uploadRecordingStaticResource technically still exists, but it just uses its internal reference to the API to call the new service. The code in both places was nearly identical, and having it as a single service allows for header usage from outside projects.
2c515a9
to
09fd228
Compare
Summary
Updated code to support header population on internal calls.
Internal listeners that send messages to interested clients need
to persist headers on calls, as original headers are not preserved.
Fixed issues with email/SMS generation.
Made some resolver get's internal _get's, in cases where headers
may not be available at that point. All instances are cases where
headers might actively interfere with the process, e.g. looking
up static resources that might not have a field populated from
headers.
Converetd uploadMediaStaticResource and uploadRecordingStaticResource
into a single new service. uploadRecordingStaticResource technically
still exists, but it just uses its internal reference to the API
to call the new service. The code in both places was nearly identical,
and having it as a single service allows for header usage from outside
projects.
References
closes #insert number here
QA Steps