Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

Conversation

speigg
Copy link
Contributor

@speigg speigg commented Nov 2, 2023

Summary

Responsiveness check often gets stuck in restart loops in local dev, because the fetch until timeout logic was incorrect. This fixes the problem.

🤖 Generated by Copilot at c92a203

This pull request refactors the instance server status fetching logic in instance-provision.class.ts to use a retry mechanism with await. This simplifies the code and reduces warnings.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at c92a203

  • Add a retry variable to control the fetch loop of instance server status (link)
  • Replace the fetch call with a while loop that uses await and checks the retry variable (link)
  • Move the warning log message to the end of the instance-provision.class.ts file, where the unresponsive instance server is removed (link)

🤖 Generated by Copilot at c92a203

To fetch the server status with grace
We use a retry variable in place
With a while loop we wait
And avoid warnings we hate
Making the code more readable and clear in this case

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@barankyle barankyle added this pull request to the merge queue Nov 2, 2023
Merged via the queue into dev with commit 9d050cc Nov 2, 2023
@barankyle barankyle deleted the fix-instance-provision-responsiveness-check branch November 2, 2023 21:23
@speigg speigg restored the fix-instance-provision-responsiveness-check branch November 2, 2023 23:58
@speigg speigg deleted the fix-instance-provision-responsiveness-check branch November 2, 2023 23:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants