This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Fix instance-provision responsiveness check #9196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Responsiveness check often gets stuck in restart loops in local dev, because the fetch until timeout logic was incorrect. This fixes the problem.
🤖 Generated by Copilot at c92a203
This pull request refactors the instance server status fetching logic in
instance-provision.class.ts
to use a retry mechanism withawait
. This simplifies the code and reduces warnings.References
closes #insert number here
Explanation
🤖 Generated by Copilot at c92a203
retry
variable to control the fetch loop of instance server status (link)fetch
call with awhile
loop that usesawait
and checks theretry
variable (link)instance-provision.class.ts
file, where the unresponsive instance server is removed (link)🤖 Generated by Copilot at c92a203
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist