Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

Conversation

HexaField
Copy link
Contributor

@HexaField HexaField commented Oct 19, 2023

Summary

Somehow the visible input on the ground plane editor was removed. This is a nice feature, especially for AR to allow shadows to be cast on the ground without the ground being visible.

🤖 Generated by Copilot at d6de7c3

Added a UI option to toggle the visibility of the ground plane component in the editor. Updated the localization file to reflect the new and removed properties of the component.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at d6de7c3

  • Added visible property to ground plane component and editor (link, link, link)
  • Removed receiveShadow and generateNavmesh properties from ground plane component and editor (link)

🤖 Generated by Copilot at d6de7c3

The ground plane is hidden from our sight
We edit its labels and info with might
We don't need shadows or navmeshes here
We are the masters of the GroundPlaneComponent

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

Copy link
Contributor

@SYBIOTE SYBIOTE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have the visible component and its UI for every entity, do we require an explict studio UI for visible in ground plane as well?

@HexaField
Copy link
Contributor Author

we have the visible component and its UI for every entity, do we require an explict studio UI for visible in ground plane as well?

The visible component tells the renderer what to render, the visible property on the ground plane is needed separately to create a transparent object that can receive shadows. This is used in AR scenes

@anselm
Copy link
Contributor

anselm commented Oct 23, 2023

Liam/Gheric suggest calling it transparent or xrshadowcastingplane or something more specific to the role of still being a shadow target while not being visible.

@HexaField HexaField merged commit a7f388d into dev Oct 24, 2023
@HexaField HexaField deleted the ground-plane-visibility branch October 24, 2023 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants