Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

Conversation

HexaField
Copy link
Contributor

@HexaField HexaField commented Oct 11, 2023

Summary

🤖 Generated by Copilot at a5ccb4e

This pull request improves the robustness and performance of the WebGLRendererSystem by handling the case when the canvas element is missing and caching the canvas parent element. It changes the file packages/engine/src/renderer/WebGLRendererSystem.ts.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at a5ccb4e

  • Prevent rendering errors when canvas element is not mounted (link)
  • Optimize canvas parent element query by using a variable (link)

🤖 Generated by Copilot at a5ccb4e

No canvas, no crash
WebGLRendererSystem
Optimized for speed

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@HexaField HexaField marked this pull request as ready for review October 16, 2023 23:35
@speigg speigg added this pull request to the merge queue Oct 17, 2023
Merged via the queue into dev with commit 70646a9 Oct 17, 2023
@speigg speigg deleted the optimize-offscreen-render branch October 17, 2023 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants