perf(item): remove delegatesFocus patch for iOS 13 #25822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: core
averyjohnston
approved these changes
Aug 25, 2022
liamdebeasi
added a commit
that referenced
this pull request
Aug 25, 2022
This reverts commit ee3467c.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #25273
iOS 13 required a delegatesFocus patch to be added due to this WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=214859
Ionic 7 only supports iOS 14+, so this patch is no longer needed. It was also interfering with non-iOS platforms (see linked issue). This proposed change is also needed for #18532.
What is the new behavior?
Does this introduce a breaking change?
Other information