Firestore map keys considered invalid when containing `/` characters

[a-shine]

Describe the bug
We often store mappings of document reference paths (as strings) to values inside documents.

e.g.

{
    'activityType': 'activityA',
    'agents': {'products/product-a': 5.0},
}

Using the native Firestore libraries, we encountered no issues writing Firestore maps inside our documents that contain / characters in the key string. This seemingly is allowed in Firestore documents but triggers the Invalid argument (path) exception when attempting to write a document containing the map using the library.

  Invalid argument (path): Paths can't be empty and must not contain '*~/[]'.: "products/product-a"
  package:dart_firebase_admin/src/google_cloud_firestore/path.dart 255:7          new _StringFieldMask
  package:dart_firebase_admin/src/google_cloud_firestore/path.dart 289:47         new FieldPath.from
  package:dart_firebase_admin/src/google_cloud_firestore/field_value.dart 391:44  _validateUserInput
  package:dart_firebase_admin/src/google_cloud_firestore/field_value.dart 369:9   _validateUserInput.<fn>
  package:collection/src/list_extensions.dart 122:13                              ListExtensions.forEachIndexed
  package:dart_firebase_admin/src/google_cloud_firestore/field_value.dart 368:13  _validateUserInput
  package:dart_firebase_admin/src/google_cloud_firestore/field_value.dart 384:9   _validateUserInput
  package:dart_firebase_admin/src/google_cloud_firestore/write_batch.dart 293:3   _validateDocumentData
  package:dart_firebase_admin/src/google_cloud_firestore/write_batch.dart 158:5   WriteBatch.set
  package:dart_firebase_admin/src/google_cloud_firestore/reference.dart 301:54    DocumentReference.set
  test/data/services/firestore_api_service_test.dart 379:54                       main.<fn>.<fn>

To Reproduce

   await firestore.doc("activities/new-activity").set({
        'activityType': 'activityA',
        'agents': {'products/product-a': 5.0}
      });

Expected behavior
This should be a valid document and written to Firestore with the string key "products/product-a" in the document's list of product -> value mappings.

[a-shine]

I quickly checked the Firestore UI and can confirm that I can add attribute names containing / for both root-level document attribute names and map keys in Firestore document map attributes.

[HeySreelal]

I've just added a PR that fixes this. There was an unnecessary check in the _StringFieldMask constructor that thrown this error. And it seems like all of these *~/[] characters are supported in Firestore field paths. Not sure why there was this check initially.

[a-shine]

Thanks @HeySreelal, for the quick PR. Much appreciated!

After some digging yesterday, I found the unnecessary check as well and tentatively deployed to our test environment - it seems to be working fine. However, I am not sure about any other unforeseen consequences of removing the check.

[rrousselGit]

This is a fork of the official JS Admin SDK. It has this error too, so removing it isn't a question.
But we should make sure that it doesn't trigger in cases where the error doesn't trigger when using JS

[HeySreelal]

Oops, sorry @rrousselGit! Forgot to check the JS SDK. It seems that one has the same issue.