Skip to content

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Apr 28, 2025

Context

Useful with #1029
Some wallet URLs have redirects, and the resulting resourceServer could be something that corresponds to a different wallet as well.

With this info stored, we can:

  • help distinguish those redirect wallets (MMAON, ilp.dev) from their managing wallets
  • display the wallet address that user entered in UI - like UI showing ilp.dev instead of ilp.interledger.cards address (not done yet)

Changes proposed in this pull request

  • Store walletAddressUrl as walletAddress.url in extension storage.
    • The url property isn't part of standard WalletAddress response, so it's safe to add to storage within this object.
    • The field is marked optional as it doesn't exist on already connected wallets.

Example: User input $ilp.interledger-test.dev/sid at connectWallet gets stored like this:
image

@sidvishnoi sidvishnoi requested a review from DarianM April 28, 2025 13:40
@github-actions github-actions bot added area: background Improvements or additions to extension background script area: shared Changes to shared libraries and utilities labels Apr 28, 2025
Copy link
Contributor

github-actions bot commented Apr 28, 2025

Extension builds preview

Name Link
Latest commit 6807719
Latest job logs Run #14732184460
Chrome (990.17KB)Download
Firefox (990.2KB)Download

@sidvishnoi sidvishnoi merged commit a13e2a6 into main Apr 29, 2025
10 checks passed
@sidvishnoi sidvishnoi deleted the store-wallet-url-from-user branch April 29, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script area: shared Changes to shared libraries and utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants