Skip to content

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Apr 21, 2025

Context

Fixes #1021

Changes proposed in this pull request

  • Handle the case of not-3-letter currency by using uppercase-currency as code to prevent crash (in formatCurrency, getCurrencySymbol).
  • Add unit tests

@sidvishnoi sidvishnoi requested a review from DarianM April 21, 2025 12:36
@github-actions github-actions bot added area: tests Improvements or additions to tests area: pages Changes to any of extension's pages labels Apr 21, 2025
@sidvishnoi sidvishnoi changed the title fix(popup): don't crash when not using 3-letter currencies fix(pages): don't crash when not using 3-letter currencies Apr 21, 2025
Copy link
Contributor

Extension builds preview

Name Link
Latest commit 0e1ca8d
Latest job logs Run #14573584872
BadgeDownload
BadgeDownload

@sidvishnoi sidvishnoi merged commit 3b7fea2 into main Apr 23, 2025
11 checks passed
@sidvishnoi sidvishnoi deleted the non-standard-currencies branch April 23, 2025 11:29
@sidvishnoi sidvishnoi linked an issue Apr 24, 2025 that may be closed by this pull request
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: pages Changes to any of extension's pages area: tests Improvements or additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MMAON as wallet Popup crashes when using non-3-letter currencies
2 participants