Skip to content

Conversation

sidvishnoi
Copy link
Member

Context

Had all sorts of utils in shared/helpers.ts.

Changes proposed in this pull request

  • Split utils from shared/helpers.ts into separate files (in shared/helpers), separated by kind of things utils are used for.
  • Move some utils to background & pages, as they're not really "shared" utils.

@github-actions github-actions bot added area: content Improvements or additions to extension content script area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup area: tests Improvements or additions to tests area: pages/app area: pages/notification area: pages Changes to any of extension's pages area: shared Changes to shared libraries and utilities labels Apr 21, 2025
Copy link
Contributor

Extension builds preview

Name Link
Latest commit 20d72a9
Latest job logs Run #14572567087
BadgeDownload
BadgeDownload

Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@sidvishnoi
Copy link
Member Author

Merging without review as just moving things around and tests pass (Edge e2e is separate issue).

@sidvishnoi sidvishnoi merged commit b56eca8 into main Apr 21, 2025
11 of 12 checks passed
@sidvishnoi sidvishnoi deleted the refactor-utils branch April 21, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script area: content Improvements or additions to extension content script area: pages/app area: pages/notification area: pages Changes to any of extension's pages area: popup Improvements or additions to extension popup area: shared Changes to shared libraries and utilities area: tests Improvements or additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant