IntercomException method isValidIntercomError() should be static

[frankmichel]

The method isValidIntercomError() should be static, otherwise an error will be thrown:
Non-static method Intercom\Exception\IntercomException::isValidIntercomError() should not be called statically

[nurazem]

Hi @frankmichel . Could you provide me with the steps to reproduce this error?

[aaronfessler]

I get the same error. Really, anything that generates any sort of intercom error will give this. Even something as simple as passing in an invalid API key generates this error for me.

PHP Strict Standards:  Non-static method Intercom\Exception\IntercomException::isValidIntercomError() should not be called statically in /Users/aaron/Sites/twine/lib/vendor/intercom/intercom-api-client/src/Intercom/Exception/IntercomException.php on line 24

Strict Standards: Non-static method Intercom\Exception\IntercomException::isValidIntercomError() should not be called statically in /Users/aaron/Sites/twine/lib/vendor/intercom/intercom-api-client/src/Intercom/Exception/IntercomException.php on line 24
PHP Strict Standards:  Non-static method Intercom\Exception\IntercomException::isValidIntercomError() should not be called statically in /Users/aaron/Sites/twine/lib/vendor/intercom/intercom-api-client/src/Intercom/Exception/IntercomException.php on line 52

@nurazem, perhaps your PHP error/notice settings are too loose to see? Try E_ALL | E_STRICT.

[frankmichel]

@nurazem, just look at this file:

/intercom-php/src/Intercom/Exception/IntercomException.php

On line [24] you are calling if (!static::isValidIntercomError($response->json()))

However on line [64] you are not declaring the private function as static:

private function isValidIntercomError($response_body)

Line [64] should be:

private static function isValidIntercomError($response_body)

[dehora]

@frankmichel @nurazem @aaronfessler I've merged a change to make the call static and also inverted the condition so the exception is populated with error data.

/ @josler @bobjflong