Skip to content

Refactor to Azure Workspace Module #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 11, 2023
Merged

Refactor to Azure Workspace Module #3

merged 11 commits into from
May 11, 2023

Conversation

shreejam21
Copy link
Contributor

@shreejam21 shreejam21 commented May 8, 2023 •
edited
Loading

  • Refactored the code to just have Workspace Logic
  • Refactored Examples
  • Rewrote READMEs
  • Tested Examples

lucasmelogithub
lucasmelogithub reviewed May 10, 2023
View reviewed changes
lucasmelogithub
lucasmelogithub reviewed May 10, 2023
View reviewed changes
lucasmelogithub
lucasmelogithub reviewed May 10, 2023
View reviewed changes
@lucasmelogithub
Copy link
Contributor

Please see comments @shreejam21

@shreejam21
Copy link
Contributor Author

shreejam21 commented May 10, 2023 •
edited
Loading

made the changes based on comment

lucasmelogithub
lucasmelogithub approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@lucasmelogithub lucasmelogithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approving.

@lucasmelogithub lucasmelogithub merged commit 2cb1439 into main May 11, 2023
@lucasmelogithub lucasmelogithub deleted the shreejan-refactor branch May 11, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasmelogithub lucasmelogithub lucasmelogithub approved these changes

@daveshrestha-intel daveshrestha-intel Awaiting requested review from daveshrestha-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreejam21 @lucasmelogithub