Fix/find macos homebrew #66
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stevelr <[email protected]>
Signed-off-by: stevelr <[email protected]>
abrown
reviewed
Aug 23, 2023
There was a problem hiding this comment.
@stevelr, good to see you! I think this change makes sense in general and I believe you can safely ignore the dependency issues (I'll have to update some crates somewhere). But I did want to make one onerous request: is there any way you can add a CI task to install OpenVINO via homebrew in a GitHub runner so we can check this out? If it's too difficult for some reason feel free to let me know, but if you are able to get something like that working we can use it to check the functionality here and eventually even move it into https://github.com/abrown/install-openvino-action.
|
As of e334a47, this issue is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macos, also look in homebrew installation folders:
$HOMEBREW_PREFIX/liband/opt/homebrew/libAlso fixed a couple clippy errors and a build error in xtask.