Skip to content

Conversation

abrown
Copy link
Contributor

@abrown abrown commented Sep 26, 2024

This will integrate clippy with GitHub's code scanning feature.

This will integrate `clippy` with GitHub's code scanning feature.
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

pull_request:
branches: ["main"]
schedule:
- cron: "3 2 * * 1"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to run as a cron if the analysis tool is static? Why not just run once when a new patchset is initiated or updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well run it once a week in case the underlying tools change and the repository has not had a PR in a while.

@jlb6740
Copy link

jlb6740 commented Sep 26, 2024

Had a question but approved assuming it's not a concern.

Copy link
Contributor

@rahulchaphalkar rahulchaphalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@abrown abrown merged commit 8346d35 into intel:main Sep 26, 2024
17 checks passed
@abrown abrown deleted the code-scan branch September 26, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants