Skip to content

Conversation

rahulchaphalkar
Copy link
Contributor

No description provided.

Co-authored-by: Bradley Odell <[email protected]>
@rahulchaphalkar rahulchaphalkar requested a review from abrown May 28, 2024 16:51
Copy link
Contributor

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor fix-ups.

Comment on lines 124 to 125
/// Get the single input port of the compiled model,
/// which only support single input model.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Get the single input port of the compiled model,
/// which only support single input model.
/// Get the single input port of the compiled model, which must have a single input.

Wonder what happens if it doesn't.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In debug, it would throw an assertion and terminate -

        OPENVINO_ASSERT(inputs.size() == 1,
                        "CompiledModel::input() must be called on a compiled model with exactly one parameter.");
        return inputs.at(0);

In release, it would just return first (0th) index input

@rahulchaphalkar rahulchaphalkar merged commit 0d93626 into intel:main May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants