Rename instance field to ptr
#101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is another refactor to align more closely with Rust conventinos on the naming of the pointers that the `openvino` crate must pass around. Since Rust tends to use `ptr` to refer to this kind of thing (e.g., `slice::as_ptr`), this change removes the overloaded `instance` term by: - replacing `instance` with `ptr` as the field name for the Rust wrapper structs; in the cases where we do not hold a pointer, let's use `c_struct` instead (which should help differentiate what's going on) - replacing `new_from_instance()` and `instance()` with `from_ptr()` and `as_ptr()`; it would be nice to use `From` and `Into` implementations here but we don't want to expose the `ov_*` pointer types in the public API of the `openvino` crate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for what this entails; this is a refactoring and should not involve any logic changes.