[SYCL][Driver] Fix default device compilation for CL mode #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling with -fsycl and providing no triples to some -fsycl*targets option, a default device target triple is chosen. For CL mode, it is spir64-unknown-[[os]]-sycldevice-coff. Leaving object format unset for CL mode is not right, as this results in SYCLActionBuilder's inability to find the toolchain with a matching triple. Signed-off-by: Artem Gindinson <[email protected]>
AGindinson
force-pushed
the
private/agindins/fix-clang-cl
branch
2 times, most recently
from
6f91538 to
259f39e
Compare
mdtoguchi
previously approved these changes
Oct 15, 2019
v-klochkov
previously approved these changes
Oct 15, 2019
AGindinson
force-pushed
the
private/agindins/fix-clang-cl
branch
from
259f39e to
70aa1da
Compare
v-klochkov
approved these changes
Oct 15, 2019
mdtoguchi
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with -fsycl and providing no triples to some
-fsycl*targets option, a default device target triple is chosen.
For CL mode, it is spir64-unknown-[[os]]-sycldevice-coff. Leaving
object format unset for CL mode resulted in inability to find the
toolchain with a matching triple.
Signed-off-by: Artem Gindinson [email protected]