[SYCL] Add generation of sycl-module-id attribute for kernels #694
Conversation
|
This is part of device code splitting feature. Please refer #631 for full design doc. |
There was a problem hiding this comment.
Is it reliable way to get unique id for the module? Can't we have two different modules with the same module id?
There was a problem hiding this comment.
This is a valid concern. It seems hard to come up with 100% reliable ID, so at least a TODO should be added to the code.
Other ideas to make it more reliable: add compilation time, addresses of Function objects corresponding to kernels in this translation unit.
Not 100% reliability should be OK, though, as the worst result is kernels going to the same module rather than different ones.
There was a problem hiding this comment.
Added a TODO comment to address this concern later.
This attribute contains string with module identifier. This information will be used to split fully linked device modules into smaller ones. Signed-off-by: Mariya Podchishchaeva <[email protected]> Signed-off-by: Sergey Semenov <[email protected]>
Signed-off-by: Sergey Semenov <[email protected]>
sergey-semenov
force-pushed
the
private/mpodchis/module-id-attr
branch
from
c5f18db to
885515a
Compare
|
Per our agreement with Mariya, I'll be driving this PR for now. |
sergey-semenov
force-pushed
the
private/mpodchis/module-id-attr
branch
from
885515a to
6e06ec8
Compare
|
Ping. |
Fznamznon
changed the title
New option allows to specify which version of extended instruction set for representing debug info should be used
5 participants
This attribute contains string with module identifier. This information
will be used to split fully linked device modules into smaller ones.
Signed-off-by: Mariya Podchishchaeva [email protected]