Skip to content

[SYCL] Retain PI events until they have signaled #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2021
Merged

[SYCL] Retain PI events until they have signaled #3350

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9db080b
[SYCL] Retain PI events until they have signalled
smaslov-intel Mar 12, 2021
1dc76ce
[SYCL] Make sure to only release an event once
smaslov-intel Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions sycl/plugins/level_zero/pi_level_zero.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,15 @@ createEventAndAssociateQueue(pi_queue Queue, pi_event *Event,
// In piEventRelease, the reference counter of the Queue is decremented
// to release it.
piQueueRetainNoLock(Queue);

// SYCL RT does not track completion of the events, so it could
// release a PI event as soon as that's not being waited in the app.
// But we have to ensure that the event is not destroyed before
// it is really signalled, so retain it explicitly here and
// release in cleanupAfterEvent.
//
PI_CALL(piEventRetain(*Event));

return PI_SUCCESS;
}

Expand Down Expand Up @@ -3863,6 +3872,10 @@ static pi_result cleanupAfterEvent(pi_event Event) {
EventsToBeReleased);
PI_CALL(piEventRelease(DepEvent));
}

// Finally, release this event since we explicitly retained it on creation.
PI_CALL(piEventRelease(Event));

return PI_SUCCESS;
}

Expand Down