Skip to content

[SYCL][Doc] Require put link to test PR in commit message #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 14, 2021
Merged

[SYCL][Doc] Require put link to test PR in commit message #3010

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e5eaff
[SYCL][Doc] Require put link to test PR in commit message
vladimirlaz Jan 11, 2021
6c2dc7f
Apply review comments
vladimirlaz Jan 12, 2021
dfdb2af
Apply suggestions from code review
vladimirlaz Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,14 @@ see [ABI Policy Guide](sycl/doc/ABIPolicyGuide.md) for more information.
- For any DPC++-related commit, the `[SYCL]` tag should be present in the
commit message title. To a reasonable extent, additional tags can be used
to signify the component changed, e.g.: `[PI]`, `[CUDA]`, `[Doc]`.
- For product changes which require modification in tests outside of the current repository
(see [Test DPC++ toolchain](sycl/doc/GetStartedGuide.md#test-dpc-toolchain)),
the commit message should contain the link to corresponding test PR, e.g.: E2E
test changes are available under intel/llvm-test-suite#88 or SYCL
conformance test changes are available under KhronosGroup/SYCL-CTS#65 (see
[Autolinked references and URLs](https://docs.github.com/en/free-pro-team/github/writing-on-github/autolinked-references-and-urls)
for more details). The same message should be present both in commit
message and in PR description.

### Review and acceptance testing

Expand Down