[SYCL] Reword some diagnostics to be more consistent. #2924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diagnostics in Clang do not start with a capital letter or contain terminating punctuation. Aside from rewording, this is an NFC change.
Fznamznon
approved these changes
Dec 21, 2020
|
Please add [SYCL] tag to the commit message, if the commit is related to DPC++ changes. See https://github.com/intel/llvm/blob/sycl/CONTRIBUTING.md#commit-message . |
AaronBallman
changed the title
Can do, thank you for pointing that out! |
elizabethandrews
approved these changes
Dec 21, 2020
jsji
pushed a commit
that referenced
this pull request
Feb 25, 2025
…#2924) This fixes the mangling in enqueue_kernel.cl test. Without the fix we get such mangled function: @_Z21__spirv_EnqueueKernelP13__spirv_QueueiPciPU3AS4P19__spirv_DeviceEventS5_U13block_pointerFvvEPU3AS4cii instead of the expected: @_Z21__spirv_EnqueueKernelP13__spirv_Queuei9ndrange_tiPU3AS4P19__spirv_DeviceEventS5_U13block_pointerFvvEPU3AS4cii Original commit: KhronosGroup/SPIRV-LLVM-Translator@6675e28ce8621cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnostics in Clang do not start with a capital letter or contain
terminating punctuation. Aside from rewording, this is an NFC change.