[SYCL][NFC] Fix static code analysis concerns #2822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found via a static-analysis tool:
Inside VisitTemplateTemplateArgument()
TemplateDecl *TD = TA.getAsTemplate().getAsTemplateDecl(); --->Pointer 'TD' returned from call to function 'getAsTemplateDecl' may be NULL
TemplateParameterList *TemplateParams = TD->getTemplateParameters(); --> will be dereferenced here
This patch fixes null pointer dereference issues in SemaSYCL.cpp file by adding assert().
Signed-off-by: Soumi Manna <[email protected]>
smanna12
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
Fznamznon
approved these changes
Nov 26, 2020
jsji
pushed a commit
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via a static-analysis tool:
Inside VisitTemplateTemplateArgument() function:
TemplateDecl *TD = TA.getAsTemplate.getAsTemplateDecl(); ----> Pointer 'TD' may be NULL
TemplateParameterList *TemplateParams = TD->getTemplateParameters(); ---> will be dereferenced here
This patch fixes null pointer dereference issues in SemaSYCL.cpp file by adding assert().
Signed-off-by: Soumi Manna [email protected]