Skip to content

[SYCL][ESIMD] Fix LowerESIMD crash on a scalar fptoui. #2699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2021
Merged

[SYCL][ESIMD] Fix LowerESIMD crash on a scalar fptoui. #2699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions llvm/lib/SYCLLowerIR/LowerESIMD.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1239,10 +1239,11 @@ PreservedAnalyses SYCLLowerESIMDPass::run(Function &F,
if (auto CastOp = dyn_cast<llvm::CastInst>(&I)) {
llvm::Type *DstTy = CastOp->getDestTy();
auto CastOpcode = CastOp->getOpcode();
if ((CastOpcode == llvm::Instruction::FPToUI &&
DstTy->getScalarType()->getPrimitiveSizeInBits() <= 32) ||
(CastOpcode == llvm::Instruction::FPToSI &&
DstTy->getScalarType()->getPrimitiveSizeInBits() < 32)) {
if (isa<FixedVectorType>(DstTy) &&
((CastOpcode == llvm::Instruction::FPToUI &&
DstTy->getScalarType()->getPrimitiveSizeInBits() <= 32) ||
(CastOpcode == llvm::Instruction::FPToSI &&
DstTy->getScalarType()->getPrimitiveSizeInBits() < 32))) {
IRBuilder<> Builder(&I);
llvm::Value *Src = CastOp->getOperand(0);
auto TmpTy = llvm::FixedVectorType::get(
Expand Down
17 changes: 17 additions & 0 deletions llvm/test/SYCLLowerIR/scalar_fptoui.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
; This is a regression test for LowerESIMD crashing on a scalar fptoui
; instruction.
;
; RUN: opt < %s -LowerESIMD -S | FileCheck %s

target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-n8:16:32:64"
target triple = "spir64-unknown-unknown-sycldevice"

; Function Attrs: convergent norecurse
define dso_local spir_func i32 @foo(float %x) !sycl_explicit_simd !1 {
%y = fptoui float %x to i32
; check that the scalar float to unsigned int conversion is left intact
; CHECK: %y = fptoui float %x to i32
ret i32 %y
}

!1 = !{i32 0, i32 0}