Skip to content

[SYCL][USM] Initial Support for USM #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 1, 2019
Merged

[SYCL][USM] Initial Support for USM #256

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2bae2bb
Modify clang to:
jbrodman Jun 26, 2019
93e4f61
Modify test to set proper addr space for the pointer argument.
jbrodman Jun 26, 2019
62f2d11
Add kind_pointer to Integration header support in SYCL RT.
jbrodman Jun 26, 2019
ae2fc0b
Fuse tests into one.
jbrodman Jun 27, 2019
955618a
Remove env var due to new default.
jbrodman Jun 27, 2019
7673dd6
Merge branch 'sycl' into clangusm
bader Jul 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions clang/test/CodeGenSYCL/debug-info-srcpos-kernel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// RUN: DISABLE_INFER_AS=1 %clang --sycl %s -S -emit-llvm -g -o - | FileCheck %s --check-prefixes CHECK,CHECK-OLD
// RUN: %clang --sycl %s -S -emit-llvm -g -o - | FileCheck %s --check-prefixes CHECK,CHECK-NEW
// RUN: %clang --sycl %s -S -emit-llvm -g -o - | FileCheck %s --check-prefixes CHECK
//
// Verify the SYCL kernel routine is marked artificial.
//
Expand All @@ -22,8 +21,8 @@ int main() {
return 0;
}

// CHECK-OLD: define{{.*}} spir_kernel {{.*}}void @_ZTSZ4mainE15kernel_function(i32*{{.*}}){{.*}} !dbg [[KERNEL:![0-9]+]] {{.*}}{
// CHECK-NEW: define{{.*}} spir_kernel {{.*}}void @_ZTSZ4mainE15kernel_function(i32 addrspace(4)*{{.*}}){{.*}} !dbg [[KERNEL:![0-9]+]] {{.*}}{

// CHECK: define{{.*}} spir_kernel {{.*}}void @_ZTSZ4mainE15kernel_function(i32 addrspace(1)*{{.*}}){{.*}} !dbg [[KERNEL:![0-9]+]] {{.*}}{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting.
@asavonic, this looks like a bug with address space handling.

  1. Note, clang emit OpenCL kernel with "generic pointer" argument.
  2. Clang does not emit warnings about captured pointers.

I think both these issues should be fixed for the cases when USM feature is not available.

// CHECK: [[FILE:![0-9]+]] = !DIFile(filename: "{{.*}}debug-info-srcpos-kernel.cpp"{{.*}})
// CHECK: [[KERNEL]] = {{.*}}!DISubprogram(name: "_ZTSZ4mainE15kernel_function"
// CHECK-SAME: scope: [[FILE]]
Expand Down