Skip to content

[SYCL] Set "BinaryStatus" correctly in L0 plugin #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2020
Merged

[SYCL] Set "BinaryStatus" correctly in L0 plugin #2308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sycl/plugins/level_zero/pi_level_zero.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1769,13 +1769,18 @@ pi_result piProgramCreateWithBinary(pi_context Context, pi_uint32 NumDevices,
return PI_INVALID_CONTEXT;
if (!DeviceList || !NumDevices)
return PI_INVALID_VALUE;
if (!Binaries || !Lengths || !Binaries[0] || !Lengths[0])
if (!Binaries || !Lengths)
return PI_INVALID_VALUE;
if (!Program)
return PI_INVALID_VALUE;

// For now we support only one device.
assert(NumDevices == 1);
if (!Binaries[0] || !Lengths[0]) {
if (BinaryStatus)
*BinaryStatus = PI_INVALID_VALUE;
return PI_INVALID_VALUE;
}
if (DeviceList[0] != Context->Device)
return PI_INVALID_DEVICE;

Expand All @@ -1801,6 +1806,9 @@ pi_result piProgramCreateWithBinary(pi_context Context, pi_uint32 NumDevices,
} catch (...) {
return PI_ERROR_UNKNOWN;
}

if (BinaryStatus)
*BinaryStatus = PI_SUCCESS;
return PI_SUCCESS;
}

Expand Down