[SYCL][ESIMD] Fix spelling of attribute to mark ESIMD register binding. #2107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
DenisBakhvalov
approved these changes
Jul 14, 2020
romanovvlad
reviewed
Jul 16, 2020
| #include <CL/sycl/intel/esimd.hpp> | ||
|
|
||
| // This test checks that DPC++ compiler in ESIMD mode understands | ||
| // the ESIMD_PRIVATE and ESIMD_REGISTER macros |
There was a problem hiding this comment.
Not sure, this test makes sense in the SYCL dir, it basically checks frontend.
There was a problem hiding this comment.
This test includes esimd.hpp, so it can't reside in the FE
v-klochkov
approved these changes
Jul 16, 2020
jsji
pushed a commit
that referenced
this pull request
Aug 11, 2023
For AttrKind attributes, we need to convert them to the AttrKind enum before checking if it exists or adding it, otherwise it gets added as a string. Signed-off-by: Sarnie, Nick <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@d24b9c6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Konstantin S Bobrovsky [email protected]