Skip to content

[Devops] Small containers clean-up #20219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

[Devops] Small containers clean-up #20219

wants to merge 3 commits into from

Conversation

KornevNikita
Copy link
Contributor

@KornevNikita KornevNikita commented Sep 26, 2025 •
edited
Loading

  • The get_release.py script is unused. Removing.
  • don't check *.sum week, it was only needed for 45th week of 2024.
  • We don't test fpga anymore. Removing runtime installation steps.
  • Do not download .deb.gpg & .ddeb assets.

@KornevNikita
[Devops] Small containers clean-up
d5c3123 
- get_release.py is unused and likely can be removed
- we don't test fpga anymore, so I guess we don't need to install the
  runtime, so change all -> igfx, cpu. May be this part of script may be
  removed as well.
- there is some leftover after drivers install. Do not download .deb.gpg
  assets & also remove .ddeb
@KornevNikita KornevNikita requested a review from a team as a code owner September 26, 2025 16:36
sarnex
sarnex approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm minor nit

devops/scripts/install_drivers.sh Outdated
| grep ".*$UBUNTU_VER.*deb$" \
| wget -qi -
dpkg -i --force-all *.deb && rm *.deb *.sum
dpkg -i --force-all *.deb && rm *.deb *.ddeb *.sum
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if we can instead change the get_release call to be something like grep ".*$UBUNTU_VER.*\.deb$"
so we dont ever download .ddeb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it. If we don't need debug packages, I'll update this a bit later

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ive never seen a case where we actually get a crash with a stack trace that it would be useful to have symbols for, so i dont think we need them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a5b3108 updated. Also removed sum week check, as 2024 is already far away:)

@KornevNikita
Copy link
Contributor Author

KornevNikita commented Sep 26, 2025 •
edited
Loading

This is how fpga runtime is downloaded:
#12 20.89 jq: error (at <stdin>:5) (not a string): {"message":"Not Found","documentation_url":"https://docs.github.com/rest/releases/releases#get-a-release-by-tag-name","status":"404"}
I'm going to remove this part.
UPD. 9af729b

sarnex
sarnex reviewed Sep 26, 2025
View reviewed changes
devops/scripts/install_drivers.sh
| wget -qi -
get_release oneapi-src/level-zero $L0_TAG \
| grep ".*$UBUNTU_VER.*deb" \
| grep ".*$UBUNTU_VER.*deb$" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add the ddeb check here too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, actually compute runtime is the only dependency containing debug packages.

sarnex
sarnex approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarnex sarnex sarnex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KornevNikita @sarnex