[UR][Offload] Align arguments correctly #20214
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument bundle to liboffload is a C-style struct, which has alignment requirements on fields. Previously, we weren't handling this properly. This patch adds a "realise" step which plots all the arguments into a properly aligned struct.
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
pbalcer
reviewed
Sep 26, 2025
|
|
||
| // Simplified version of the CUDA adapter's argument implementation | ||
| struct OffloadKernelArguments { | ||
| struct alignas(32) OffloadKernelArguments { |
There was a problem hiding this comment.
I'm not sure I understand what this is for. Is this what CUDA/HIP drivers expect? Shouldn't we move this requirement/functionality into the plugins?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument bundle to liboffload is a C-style struct, which has
alignment requirements on fields. Previously, we weren't handling this
properly. This patch adds a "realise" step which plots all the arguments
into a properly aligned struct.