[NFCI][SYCL RTC] Refactor calculateHash/HashPreprocessedAction
#20204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Hash `UserArgList`/`BinaryFormat` before `createCommandLine`, that will allow me to move `createCommandLine` down into `SYCLToolchain` in a subsequent change. * Use a `Hasher` to "accumulate" the hash instead of manually merging multiple hash results (seems more canonical usage to me). * Sink `class HashPreprocessedAction` directly to its single use. * Add `CLANG_VERSION_STRING` to the hash as a way to represent current libsycl-jit.so version.
aelovikov-intel
requested review from
cperkinsintel and
a team
as code owners
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Sep 25, 2025
After intel#20204 it's easy to stop using the translated command line to compute the hash (by doing that on user's options + format), which in turn allows us to perform this translation in a single place.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Sep 25, 2025
After intel#20204 it's easy to stop using the translated command line to compute the hash (by doing that on user's options + format), which in turn allows us to perform this translation in a single place.
cperkinsintel
approved these changes
Sep 26, 2025
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Sep 26, 2025
After intel#20204 it's easy to stop using the translated command line to compute the hash (by doing that on user's options + format), which in turn allows us to perform this translation in a single place.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Sep 26, 2025
After intel#20204 it's easy to stop using the translated command line to compute the hash (by doing that on user's options + format), which in turn allows us to perform this translation in a single place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hasherto "accumulate" the hash instead of manually merging multiple hash results (seems more canonical usage to me).join(CommandLine, ",")but rather iterate over the vector.class HashPreprocessedActiondirectly to its single use.CLANG_VERSION_STRINGto the hash as a way to represent current libsycl-jit.so version.