[SYCL][SYCLBIN] Select best images based on state #20197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the implementation would prioritize native device code binaries over IR modules indiscriminately. However, for input state and object state, native device code images are unsuitable. As such, this commit makes it so that the native device code images are only selected when the target state is executable. As an effect of this change, input and object tests will no longer run for CUDA and HIP. This is appropriate given these targets only currently support generating native device code images, which are meant to be as close to executable state as possible. Note that the driver doesn't currently make such limitations of the generated SYCLBIN files, so producing input and object state binaries with CUDA and HIP targets will result in kernel bundles with no binary images. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Prereq to #20174 |
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
approved these changes
Sep 26, 2025
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the implementation would prioritize native device code binaries over IR modules indiscriminately. However, for input state and object state, native device code images are unsuitable. As such, this commit makes it so that the native device code images are only selected when the target state is executable.
As an effect of this change, input and object tests will no longer run for CUDA and HIP. This is appropriate given these targets only currently support generating native device code images, which are meant to be as close to executable state as possible. Note that the driver doesn't currently make such limitations of the generated SYCLBIN files, so producing input and object state binaries with CUDA and HIP targets will result in kernel bundles with no binary images.