Skip to content

[SYCL] Fix assert when calling get_binaries() on host #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 23, 2020
Merged

[SYCL] Fix assert when calling get_binaries() on host #1944

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb0f903
[SYCL] Fix assert when calling get_binaries() on host
alexanderfle Jun 22, 2020
160c65c
Update sycl/source/detail/program_impl.cpp
alexanderfle Jun 22, 2020
f0237f9
[SYCL] Apply clang-format and remove extra }
alexanderfle Jun 22, 2020
9593044
[SYCL] Apply clang-format 2
alexanderfle Jun 22, 2020
296d2f5
[SYCL] Remove strange line
alexanderfle Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions sycl/source/detail/program_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,23 +304,24 @@ kernel program_impl::get_kernel(string_class KernelName,

vector_class<vector_class<char>> program_impl::get_binaries() const {
throw_if_state_is(program_state::none);
if (is_host())
return {};

vector_class<vector_class<char>> Result;
const detail::plugin &Plugin = getPlugin();
if (!is_host()) {
vector_class<size_t> BinarySizes(MDevices.size());
Plugin.call<PiApiKind::piProgramGetInfo>(
MProgram, PI_PROGRAM_INFO_BINARY_SIZES,
sizeof(size_t) * BinarySizes.size(), BinarySizes.data(), nullptr);

vector_class<char *> Pointers;
for (size_t I = 0; I < BinarySizes.size(); ++I) {
Result.emplace_back(BinarySizes[I]);
Pointers.push_back(Result[I].data());
}
Plugin.call<PiApiKind::piProgramGetInfo>(MProgram, PI_PROGRAM_INFO_BINARIES,
sizeof(char *) * Pointers.size(),
Pointers.data(), nullptr);
vector_class<size_t> BinarySizes(MDevices.size());
Plugin.call<PiApiKind::piProgramGetInfo>(
MProgram, PI_PROGRAM_INFO_BINARY_SIZES,
sizeof(size_t) * BinarySizes.size(), BinarySizes.data(), nullptr);

vector_class<char *> Pointers;
for (size_t I = 0; I < BinarySizes.size(); ++I) {
Result.emplace_back(BinarySizes[I]);
Pointers.push_back(Result[I].data());
}
Plugin.call<PiApiKind::piProgramGetInfo>(MProgram, PI_PROGRAM_INFO_BINARIES,
sizeof(char *) * Pointers.size(),
Pointers.data(), nullptr);
return Result;
}

Expand Down