[SYCL-PTX] Add integer and shared builtins categories #1828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naghasan
force-pushed
the
victor/spirv-ptx-integer
branch
from
9e678cd to
88b19f4
Compare
Closed
bader
previously approved these changes
Jun 11, 2020
|
It was already added (already in the generator list). The change you saw for prefetch are due to license header and formatting changes, but that's on the opencl side only. |
Signed-off-by: Victor Lomuller <[email protected]> Co-authored-by: David Wood <[email protected]>
Naghasan
force-pushed
the
victor/spirv-ptx-integer
branch
from
88b19f4 to
2089cb4
Compare
|
@bader I rebased to sycl tip (in case), no change to patch itself |
againull
approved these changes
Jun 17, 2020
bader
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds all builtins from the integer and shared builtins categories.
Remove old forward declared SPIR-V builtin from the integer and shared categories.
Update the binding file using the header generator.
Add relevant binding test.
Remove XFAIL from related SYCL tests.
Signed-off-by: Victor Lomuller [email protected]