[SYCL] Handle KernelNameType templated using template template type with enum template argument #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with template template arguments which in turn is templated using enum. Signed-off-by: Elizabeth Andrews <[email protected]>
|
@premanandrao please take a look for me. |
premanandrao
reviewed
Jun 2, 2020
erichkeane
previously approved these changes
Jun 2, 2020
elizabethandrews
dismissed stale reviews from erichkeane and premanandrao
via
75e846f
erichkeane
approved these changes
Jun 2, 2020
Fznamznon
approved these changes
Jun 3, 2020
|
@bader I don't think this Jenkins issue is related to my patch. |
Okay. Do you know who is working on addressing these issues? |
No I do not. I see it is failing for other PRs too. I'm not sure how to investigate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for KernelNameType with is a template specialization class with template template arguments which in turn is templated using enum.
Signed-off-by: Elizabeth Andrews [email protected]