[SYCL] Add sycl::detail::bit_cast implementation #1762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Vodopyanov <[email protected]>
Signed-off-by: Dmitry Vodopyanov <[email protected]>
dm-vodopyanov
requested review from
AlexeySachkov,
Pennycook and
a team
as code owners
There was a problem hiding this comment.
I don't have any major objections, but would like to hear feedback from @Pennycook
s-kanaev
reviewed
May 27, 2020
Signed-off-by: Dmitry Vodopyanov <[email protected]>
Signed-off-by: Dmitry Vodopyanov <[email protected]>
|
Please, do not forget to update sycl/doc/extensions/README.md with a new status of this extension. |
|
Could you please add a little bit more information in the commit message: what bitcast does and what it is lowered to depending on the compiler used. |
Signed-off-by: Dmitry Vodopyanov <[email protected]>
…st spec Signed-off-by: Dmitry Vodopyanov <[email protected]>
|
@romanovvlad, done. |
AlexeySachkov
previously approved these changes
May 28, 2020
Pennycook
previously approved these changes
May 28, 2020
keryell
suggested changes
May 29, 2020
Signed-off-by: Dmitry Vodopyanov <[email protected]>
dm-vodopyanov
dismissed stale reviews from s-kanaev, Pennycook, and AlexeySachkov
via
eb92988
Signed-off-by: Dmitry Vodopyanov <[email protected]>
Pennycook
previously approved these changes
Jun 1, 2020
dm-vodopyanov
changed the title
s-kanaev
reviewed
Jun 2, 2020
Signed-off-by: Dmitry Vodopyanov <[email protected]>
Pennycook
approved these changes
Jun 2, 2020
keryell
reviewed
Jun 2, 2020
jbrodman
approved these changes
Jun 2, 2020
|
@dm-vodopyanov, could you update the description, please? I think it's doesn't exactly match the patch. |
|
@bader thanks, found a mistake in description (renamed sycl::intel::bit_cast to sycl::detail::bit_cast). Everything else looks good for me. If something else should be added/removed, please tell me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing SYCL_INTEL_bitcast extension which reinterprets the bits of an object as an object of a different data type calling the sycl::detail::bit_cast function. This function has the same specification as std::bit_cast, defined by C++20.
sycl::detail::bit_cast calls std::bit_cast if __cpp_lib_bit_cast macro is enabled, otherwise, it calls __builtin_bit_cast builtin for oneAPI Data Parallel C++ compiler and sycl::detail::memcpy function for other compilers.