Skip to content

[NFC][SYCL] Refactor OSUtils to use std::filesystem #16447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 3, 2025
Merged

[NFC][SYCL] Refactor OSUtils to use std::filesystem #16447

merged 5 commits into from
Jan 3, 2025

Conversation

uditagarwal97
Copy link
Contributor

@uditagarwal97 uditagarwal97 commented Dec 20, 2024 •
edited
Loading

For older gcc versions (< 8), use std::experimental::filesystem.

@uditagarwal97 uditagarwal97 self-assigned this Dec 20, 2024
@uditagarwal97 uditagarwal97 marked this pull request as ready for review December 21, 2024 19:42
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner December 21, 2024 19:42
KseniyaTikhomirova
KseniyaTikhomirova reviewed Dec 23, 2024
View reviewed changes
@KseniyaTikhomirova KseniyaTikhomirova self-requested a review January 2, 2025 10:34
KseniyaTikhomirova
KseniyaTikhomirova approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uditagarwal97 uditagarwal97 marked this pull request as draft January 2, 2025 19:00
@uditagarwal97 uditagarwal97 marked this pull request as ready for review January 2, 2025 19:08
@uditagarwal97
Copy link
Contributor Author

Hi @KseniyaTikhomirova,
Can I ask for a re-review of this PR? While trying to rebase the changes with origin/sycl, I accidently forced pushed unrelated changes. I've reverted them now.

KseniyaTikhomirova
KseniyaTikhomirova reviewed Jan 3, 2025
View reviewed changes
@KseniyaTikhomirova KseniyaTikhomirova self-requested a review January 3, 2025 16:54
KseniyaTikhomirova
KseniyaTikhomirova approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uditagarwal97
Copy link
Contributor Author

@intel/llvm-gatekeepers the PR is ready to be merged.

@aelovikov-intel aelovikov-intel merged commit f6f5d7c into intel:sycl Jan 3, 2025
15 checks passed
@uditagarwal97
Copy link
Contributor Author

PR to fix post-commit failure: #16521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KseniyaTikhomirova KseniyaTikhomirova KseniyaTikhomirova approved these changes

@aelovikov-intel aelovikov-intel Awaiting requested review from aelovikov-intel

Assignees

@uditagarwal97 uditagarwal97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uditagarwal97 @KseniyaTikhomirova @aelovikov-intel