Skip to content

Conversation

johnandersen777
Copy link

@johnandersen777 johnandersen777 commented Jun 18, 2024

image

  • TODO
    • Rebase in c794765 to resolve PURL issues

@johnandersen777 johnandersen777 requested a review from terriko June 18, 2024 04:55
@johnandersen777 johnandersen777 force-pushed the ad-hoc-cves-for-static-analysis-results-from-bandit branch 17 times, most recently from 3454a25 to af1e163 Compare June 19, 2024 00:54
@johnandersen777 johnandersen777 force-pushed the ad-hoc-cves-for-static-analysis-results-from-bandit branch from af1e163 to ead3ea1 Compare June 19, 2024 03:36
@johnandersen777
Copy link
Author

@terriko This is ready for review when you have time. Thank you in advance :)

@johnandersen777 johnandersen777 force-pushed the ad-hoc-cves-for-static-analysis-results-from-bandit branch 2 times, most recently from 95b3627 to 526f45f Compare June 20, 2024 15:25
@johnandersen777 johnandersen777 force-pushed the ad-hoc-cves-for-static-analysis-results-from-bandit branch 2 times, most recently from de41d84 to f29b251 Compare June 20, 2024 15:33
@terriko
Copy link
Contributor

terriko commented Jun 20, 2024

Was there a specific motivation for this?

I ask because our current plugin system is the thing blocking us from moving to pyproject.toml from setup.py. And honestly, that's not a thing we need but it would make a bunch of our config go into that file so we don't have to have quite as many separate configs for our linters. So I'd been wondering if we should refactor away from those plugins next time we do a big refactor. Do you know of anyone supporting out of tree stuff that this would affect?

I love refactoring the parsers to be more atomic in that they actually know what files they're scanning for, and I love the better documentation. But I"m wondering if we should rethink the plugins now before we add more of them, I guess?

@terriko
Copy link
Contributor

terriko commented Jun 20, 2024

Adding: Got some more info on the use case from @pdxjohnny and I agree that this is probably the best solution. I'll be back to do a more nitpicky code review later.

@johnandersen777
Copy link
Author

johnandersen777 commented Jun 20, 2024

I will start on un-entrypoint-zing in-tree checkers so we can move to pyproject.toml as a seperate PR, then we can have it load entrypoints from out-of-tree plugins in addition to in-tree stuff.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, there's a lot of todos in here but it doesn't feel like any of them need resolving before we can proceed.

I also feel like "parsers" may be as confusing here as "checkers" is for people with the binary checkers, but I don't have any brilliant ideas that pre-emptively solve the inherent issues of communicating in human language, so I'm going to trust in documentation to explain and we'll see how it goes, I guess?

Thanks again for this! I'm going to go ahead and merge now.

@terriko terriko merged commit d32388d into intel:main Jun 21, 2024
@johnandersen777
Copy link
Author

Woohoo thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants