Skip to content

Make access to sysfs lock-free #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −4
Open

Make access to sysfs lock-free #852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions level_zero/sysman/source/shared/linux/sysman_fs_access_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ FdCacheInterface::~FdCacheInterface() {

template <typename T>
ze_result_t FsAccessInterface::readValue(const std::string file, T &val) {
auto lock = this->obtainMutex();
std::unique_lock<std::mutex> lockObj;
if (needLock) {
lockObj = this->obtainMutex();
}

std::string readVal(64, '\0');
int fd = pFdCacheInterface->getFd(file);
Expand All @@ -84,7 +87,7 @@ ze_result_t FsAccessInterface::readValue(const std::string file, T &val) {
}

// Generic Filesystem Access
FsAccessInterface::FsAccessInterface() {
FsAccessInterface::FsAccessInterface(bool needLock) : needLock(needLock) {
pFdCacheInterface = std::make_unique<FdCacheInterface>();
}

Expand Down Expand Up @@ -398,7 +401,7 @@ ::pid_t ProcFsAccessInterface::myProcessId() {
}

// Sysfs Access
SysFsAccessInterface::SysFsAccessInterface() = default;
SysFsAccessInterface::SysFsAccessInterface() : FsAccessInterface(false) {}
SysFsAccessInterface::~SysFsAccessInterface() = default;

const std::string SysFsAccessInterface::drmPath = "/sys/class/drm/";
Expand Down
3 changes: 2 additions & 1 deletion level_zero/sysman/source/shared/linux/sysman_fs_access_interface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ class FsAccessInterface {
virtual bool directoryExists(const std::string path);

protected:
FsAccessInterface();
FsAccessInterface(bool needLock = true);
MOCKABLE_VIRTUAL std::unique_lock<std::mutex> obtainMutex();
bool needLock;

private:
template <typename T>
Expand Down