fix get power stats from turbostat for telemetry #504
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the logic for parsing turbostat output to improve how summary (platform) and package rows are identified and extracted. The changes introduce helper functions for clearer row classification and enhance compatibility with different turbostat output formats.
Row classification improvements:
isPlatformRow
helper function to accurately identify platform (summary) rows by checking thatPackage
,Die
,Node
,Core
, andCPU
are all "-" or missing. This replaces previous inline logic and improves maintainability.turbostatPlatformRows
function to useisPlatformRow
for filtering, ensuring only platform rows are returned.Package row handling enhancements:
isPackageRow
helper function to identify package rows wherePackage
is present and not "-".turbostatPackageRows
function to useisPackageRow
and to handle cases where thePackage
column is missing by inferring package information from theCPU
column. This improves robustness across different turbostat outputs.Documentation updates: