Skip to content

Conversation

harp-intel
Copy link
Contributor

Error reading SSTTF configuration results in garbled output:

image

This PR adds/improves error handling in the collection scripts and the table values function.

@harp-intel harp-intel requested a review from Copilot September 25, 2025 21:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error handling in SSTTF (SST-TF) configuration scripts to prevent garbled output when errors occur. The changes add comprehensive error checking and validation to ensure the scripts fail gracefully with clear error messages rather than producing incorrect output.

  • Added error handling and validation for pcm-tpmi command execution in SSTTF scripts
  • Added numeric validation for script output values in table processing functions
  • Implemented proper error reporting with descriptive messages to stderr

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
internal/script/script_defs.go Added error handling and numeric validation for pcm-tpmi commands in SSTTFHP and SSTTFLP scripts
internal/report/table_defs.go Added numeric validation for SSTTF table values with warning logging and graceful failure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <[email protected]>
@harp-intel harp-intel merged commit 45ceffa into main Sep 25, 2025
5 checks passed
@harp-intel harp-intel deleted the sstferr branch September 25, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant