Skip to content

Fix(aio-pika): Implement argument binding method to extract values from both args and kwargs #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2025
Merged

Fix(aio-pika): Implement argument binding method to extract values from both args and kwargs #802

merged 2 commits into from
Sep 24, 2025

Conversation

GSVarsha
Copy link
Contributor

Fix(aio-pika): Implement argument binding method to extract values from both args and kwargs

Signed-off-by: Varsha GS [email protected]

@GSVarsha GSVarsha added this to the H2-2025 milestone Sep 23, 2025
@GSVarsha GSVarsha self-assigned this Sep 23, 2025
@GSVarsha GSVarsha added WIP work in progress unittest fix labels Sep 23, 2025
@GSVarsha GSVarsha marked this pull request as ready for review September 24, 2025 07:32
@GSVarsha GSVarsha requested a review from a team as a code owner September 24, 2025 07:32
pvital
pvital requested changes Sep 24, 2025
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few requests, actually questions.

@GSVarsha GSVarsha removed the WIP work in progress label Sep 24, 2025
@GSVarsha GSVarsha requested a review from pvital September 24, 2025 09:19
pvital
pvital approved these changes Sep 24, 2025
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pvital pvital merged commit c28a94e into main Sep 24, 2025
19 checks passed
@pvital pvital deleted the fix-aiopika branch September 24, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvital pvital pvital approved these changes

Assignees

@GSVarsha GSVarsha

Labels
fix unittest
Projects
None yet
Milestone
H2-2025
Development

Successfully merging this pull request may close these issues.
2 participants
@GSVarsha @pvital