-
Notifications
You must be signed in to change notification settings - Fork 35
Kafka FUP Final #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka FUP Final #790
Conversation
a72d810
to
ea9c383
Compare
3a5c83f
to
4dd204f
Compare
A couple of words behind the need for the changes. Let's say we have two distributed environments: So the pseudo code is here, trace IDs are given as examples: env A - producer
env B - consumer
What we want is whether there is a parent span or not, to keep the incoming trace ID alive. So after this PR, what will happen in the example above is as follows: env B - consumer
|
4dd204f
to
f2a54ec
Compare
Signed-off-by: Cagri Yonca <[email protected]>
Signed-off-by: Cagri Yonca <[email protected]>
f2a54ec
to
8ea4071
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
Fixed trace correlation issues, aligned with other tracers through the tracer-test-suite.