updating autoReload feature #345
Open
+48
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angelina <[email protected]>
EnriqueL8
reviewed
Sep 16, 2025
There was a problem hiding this comment.
Thanks @aceppaluni a few comments, the autoReload was put in the wrong place
Have you tested this by changing something the config in the runtime folder of a running stack and seeing it reload it?
| initCmd.PersistentFlags().StringArrayVar(&initOptions.NodeNames, "node-name", []string{}, "Node name") | ||
| initCmd.PersistentFlags().BoolVar(&initOptions.RemoteNodeDeploy, "remote-node-deploy", false, "Enable or disable deployment of FireFly contracts on remote nodes") | ||
| initCmd.PersistentFlags().StringToStringVar(&initOptions.EnvironmentVars, "environment-vars", map[string]string{}, "Common environment variables to set on all containers in FireFly stack") | ||
| initCmd.Flags().BoolVar(&initOptions.EnableAutoReload, "auto-reload", true, "Enable config auto reload in generated FireFly configs") |
There was a problem hiding this comment.
Suggested change
| initCmd.Flags().BoolVar(&initOptions.EnableAutoReload, "auto-reload", true, "Enable config auto reload in generated FireFly configs") | |
| initCmd.Flags().BoolVar(&initOptions.EnableAutoReload, "auto-reload", true, "Enable config auto reload in FireFly Core") |
| Event *EventConfig `yaml:"event,omitempty"` | ||
| Plugins *Plugins `yaml:"plugins"` | ||
| Namespaces *NamespacesConfig `yaml:"namespaces"` | ||
| AutoReload bool `json:"autoReload" yaml:"autoReload"` |
There was a problem hiding this comment.
You only need the YAML one here
Suggested change
| AutoReload bool `json:"autoReload" yaml:"autoReload"` | |
| AutoReload bool `yaml:"autoReload"` |
There was a problem hiding this comment.
I believe this is under config so config.autoReload see https://github.com/hyperledger/firefly/blob/f67a468378abc7f512231ccda7db626845e0f1ec/internal/coreconfig/coreconfig.go#L130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates autoReload