Fix TorchDynamo crash in StaticCache by validating offloading and offload_only_non_sliding arguments #41169
+33
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #41164
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @Rocketknight1
Description
This PR addresses a bug in StaticCache that can lead to torch.compile / TorchDynamo crashes when users pass:
Root causes / API issues:
Positional flexibility vs. keyword expectations
Inconsistent argument handling across cache classes
Potential user misuse
Reproduction
Solution
Validate types in
StaticCache.__init__
:Ensure
offloading
andoffload_only_non_sliding
are bool.Raise a clear TypeError if invalid.
Catch unknown kwargs:
Raise TypeError if users pass unrecognized keyword arguments (
**kwargs
) to prevent silent misassignment.Forward **kwargs safely in children:
Deprecated children like OffloadedHybridCache are untouched for now, but any kwargs they pass are safely handled in StaticCache.
Additional Notes