[v5] Remove model_parallel deprecated feature
#41166
Merged
+61
−1,301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SunMarc
commented
Sep 25, 2025
Comment on lines
-500
to
-519
| if getattr(model, "is_parallelizable", False) and getattr(model, "model_parallel", False): | ||
| self.is_model_parallel = True | ||
| else: | ||
| self.is_model_parallel = False | ||
|
|
||
| self.is_model_parallel = False | ||
| if getattr(model, "hf_device_map", None) is not None: | ||
| devices = [device for device in set(model.hf_device_map.values()) if device not in ["cpu", "disk"]] | ||
| if len(devices) > 1: | ||
| self.is_model_parallel = True | ||
| elif len(devices) == 1: | ||
| self.is_model_parallel = self.args.device != torch.device(devices[0]) | ||
| else: | ||
| self.is_model_parallel = False | ||
|
|
||
| # warn users | ||
| if self.is_model_parallel: | ||
| logger.info( | ||
| "You have loaded a model on multiple GPUs. `is_model_parallel` attribute will be force-set" | ||
| " to `True` to avoid any unexpected behavior such as device placement mismatching." | ||
| ) |
There was a problem hiding this comment.
this is what changed in trainer cc @qgallouedec
SunMarc
changed the title
model_parallelmodel_parallel deprecated feature
|
[For maintainers] Suggested jobs to run (before merge) run-slow: bloom, camembert, codegen, decision_transformer, falcon_mamba, gpt2, gpt_neo, gpt_neox_japanese, gptj, imagegpt, kosmos2_5, lilt, luke, mamba, modernbert_decoder, moshi |
Cyrilvallez
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes deprecates code related to
model_parallelfeature in the modeling as well as in Trainer. This was a feature that was added only for a few models like t5 and gpt2 but eventually we switched to using device_map and tp now.For the models, we removes
is_parallelizableandmodel_parallelattributes and some deprecated methods.For Trainer, we remove a small section related to
model_parallel.