Handle HF_TOKEN
in ApiBuilder
for candle/tests
#724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the
HF_TOKEN
handling within theApiBuilder
for thedownload_artifacts
function in thebackends/candle/tests
as it was required for #718, given thatHF_TOKEN
is not automatically parsed and it was mistaken with the cached Hugging Face Token, hence the CI was failing but that was unrelated to the token used in CI, but rather to a wrong configuration aroundApiBuilder
(kudos to @paulinebm for spotting, and thanks also to @glegendre01 for helping out with theHF_TOKEN
).Additionally, this PR removes the
HF_HUB_USER_AGENT_ORIGIN
environment variable handling for the tests as it's never defined and not really used at all.Before submitting
insta
snapshots?Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.