Skip to content

Conversation

alvarobartt
Copy link
Member

What does this PR do?

This PR adds the HF_TOKEN handling within the ApiBuilder for the download_artifacts function in the backends/candle/tests as it was required for #718, given that HF_TOKEN is not automatically parsed and it was mistaken with the cached Hugging Face Token, hence the CI was failing but that was unrelated to the token used in CI, but rather to a wrong configuration around ApiBuilder (kudos to @paulinebm for spotting, and thanks also to @glegendre01 for helping out with the HF_TOKEN).

Additionally, this PR removes the HF_HUB_USER_AGENT_ORIGIN environment variable handling for the tests as it's never defined and not really used at all.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines.
  • Did you write any new necessary tests? If applicable, did you include or update the insta snapshots?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@alvarobartt alvarobartt merged commit d22a2c2 into main Sep 19, 2025
14 checks passed
@alvarobartt alvarobartt deleted the use-hf-token-in-tests branch September 19, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants