Skip to content

fix: metrics unbounded memory #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix: metrics unbounded memory #409

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06bcdc2
fix: metrics unbounded memory
OlivierDehaene Sep 17, 2024
2711d2e
remove comment
OlivierDehaene Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions router/src/http/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1634,9 +1634,12 @@ pub async fn run(
}
});

let prom_handle = prom_builder
.install_recorder()
.context("failed to install metrics recorder")?;
// See: https://github.com/metrics-rs/metrics/issues/467#issuecomment-2022755151
let (recorder, _) = prom_builder
.build()
.context("failed to build prometheus recorder")?;
let prom_handle = recorder.handle();
metrics::set_global_recorder(recorder).context("Failed to set global recorder")?;

// CORS layer
let allow_origin = allow_origin.unwrap_or(AllowOrigin::any());
Expand Down
Loading