Skip to content

Add optional CORS allow any option value in http server cli #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Add optional CORS allow any option value in http server cli #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions router/src/http/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1410,11 +1410,15 @@ pub async fn run(
// map to go inside the option and then map to parse from String to HeaderValue
// Finally, convert to AllowOrigin
let allow_origin: Option<AllowOrigin> = cors_allow_origin.map(|cors_allow_origin| {
AllowOrigin::list(
cors_allow_origin
.into_iter()
.map(|origin| origin.parse::<HeaderValue>().unwrap()),
)
if cors_allow_origin.iter().any(|origin| origin == "*") {
AllowOrigin::any()
} else {
AllowOrigin::list(
cors_allow_origin
.into_iter()
.map(|origin| origin.parse::<HeaderValue>().unwrap()),
)
}
});

let prom_handle = prom_builder
Expand Down