feat: support vertex api endpoint #183
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philschmid
reviewed
Mar 5, 2024
philschmid
reviewed
Mar 5, 2024
Comment on lines
+1222
to
+1223
| // Vertex compat route | ||
| .route("/vertex", post(vertex_compatibility)) |
There was a problem hiding this comment.
This should not be needed since we only need the endpoint when /env is set.
There was a problem hiding this comment.
in the TGI case we also always include the endpoint and only conditionally add the api docs. Should we avoid adding it in both cases if the feature is not on?
|
closing in favor of newer PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new endpoint for vertex support and conditionally includes openapi docs for this endpoint when built with the
googlefeature